This repository was archived by the owner on Jun 26, 2020. It is now read-only.
webpack to emit file with same name as in source dir #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use our existing attached events so that it works even if we attach later.
Contributor
Author
|
closing this PR as deepak-jacob:master is going diverge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description :
basepath: /shells/chrome/
Seeing "build/inject.js" in "manifest.json" will think "src/inject.js" is main entry point, as the file with that name exists.
But actually inject.js in manifest.json is src/GlobalHook.js which webpack emits as build/inject.js.
I feel like its little confusing, as I need to look into webpack config as well to see which file is mapped to inject.js.
Reject the PR if this is done on purpose or as a workaround.